Skip to content

[ceph-make-check-periodic-ppc64] Added support for ppc64 runners#2492

Merged
zmc merged 1 commit into
ceph:mainfrom
anshuman-agarwala:power-support
Jun 18, 2026
Merged

[ceph-make-check-periodic-ppc64] Added support for ppc64 runners#2492
zmc merged 1 commit into
ceph:mainfrom
anshuman-agarwala:power-support

Conversation

@anshuman-agarwala

@anshuman-agarwala anshuman-agarwala commented Nov 10, 2025

Copy link
Copy Markdown
Member

This PR adds support for running make check job on Power hardware.

@ceph-jenkins

Copy link
Copy Markdown

Can one of the admins verify this patch?

@anshuman-agarwala anshuman-agarwala force-pushed the power-support branch 2 times, most recently from c7048b8 to bed38a4 Compare November 10, 2025 05:23
@jmundack

Copy link
Copy Markdown
Contributor

can we add in some details on why we are adding this in?

also - do we have enough runners in the lab for this?

@anshuman-agarwala

Copy link
Copy Markdown
Member Author

can we add in some details on why we are adding this in?

also - do we have enough runners in the lab for this?

I've added some detail on what this does in the description.
As for the runners, they will be provided by my team at IBM.
We had a discussion a while back with some folks from the Ceph engineering team about running make check on power. We were told that they'll be fine with it as long as we maintain the code and hardware for it.
This PR is a Draft since we still have some things to fix on our end.

@anshuman-agarwala anshuman-agarwala force-pushed the power-support branch 2 times, most recently from 7402b9d to a1acd92 Compare November 17, 2025 05:45
@jmundack

Copy link
Copy Markdown
Contributor

thanks for the context.!

can this be like a weekly job rather than a PR check? especially in the beginning while resources are flushed out (gear as well as effort to maintain this)

@anshuman-agarwala

Copy link
Copy Markdown
Member Author

Sure! I've changed the job cadence to weekly.

@anshuman-agarwala anshuman-agarwala changed the title [ceph-pull-requests-ppc64] Added support for ppc64 runners [ceph-make-check-periodic-ppc64] Added support for ppc64 runners Nov 27, 2025
@anshuman-agarwala anshuman-agarwala marked this pull request as ready for review June 15, 2026 03:08

@zmc zmc left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

just some minor suggestions

Comment thread ceph-make-check-periodic-ppc64/build/build Outdated
Comment thread ceph-make-check-periodic-ppc64/build/build
Comment thread ceph-make-check-periodic-ppc64/build/build Outdated
Comment thread ceph-make-check-periodic-ppc64/build/kill-tests
node: 'ppc64 && (installed-os-noble || centos9)'
parameters:
- string:
name: ghprbPullId

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would suggest renaming this parameter since the (deprecated) ghprb plugin isn't being used here

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've renamed this parameter.

Signed-off-by: Anshuman <anshuman@ibm.com>

@zmc zmc left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for making those changes!

@zmc zmc merged commit 38144b0 into ceph:main Jun 18, 2026
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants